Merged
Conversation
- Remove mat-card and mat-card-content wrappers from billable metrics, plans, and taxes tables - Remove unused --custom-mat-form-field-height CSS variable from widget styles - Simplify table markup by using direct table-scroll divs instead of card containers
…n/proxy-ui into divyanshu-dev
![windsurf-bot[bot]](https://avatars.githubusercontent.com/in/1066231?s=60&v=4){kind=small}
| <span | ||
| [matTooltip]="element.reference_id" | ||
| matTooltipPosition="above" | ||
| class="cursor-pointer font-mono text-xs px-2 py-0.5 rounded-4 min-w-[150px]" |
There was a problem hiding this comment.
The reference_id span has been changed from cursor-default to cursor-pointer, but there doesn't appear to be any click handler or interactive behavior associated with it. This might confuse users who expect something to happen when they click. Consider either adding interactive behavior or keeping it as cursor-default.
| <th mat-header-cell *matHeaderCellDef mat-sort-header class="width-md-300">Reference Id</th> | ||
| <td mat-cell *matCellDef="let element" data-label="Reference Id"> | ||
| @if (!loading.dataLoading) { | ||
| <div class="flex items-center gap-2 max-md:flex-col max-md:items-end"> |
There was a problem hiding this comment.
The responsive design for reference_id has been improved with max-md:flex-col and max-md:items-end, but this could cause the copy button to appear disconnected from the ID it's copying on mobile devices. Consider adding a visual indicator to maintain the relationship between the ID and its copy button when stacked vertically.
- Add height: 100% to host elements in feature, log, and user management components for proper layout - Simplify client switcher menu by removing virtual scroll for better performance - Increase client list page size from 25 to 200 items - Add "Active" badge to current client in switcher dropdown - Refactor user profile section to use ng-template for display picture reusability - Improve responsive behavior of sidebar elements with conditional class bindings - Update client switcher to only show dropdown when multiple
Saurabh186
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.